Travis: move deploy into system tests phase #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis does not retain any files between different stages (or jobs). Because the traceability report is generated during the system test stage, this commit moves the deploy steps into the system test stage where the file is actually available.
karthikmswamy
approved these changes
Jul 23, 2020
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Looks good to me. I just have a minor comment about the naming and os.
| condition: $TRAVIS_TAG =~ ^rel/.*$ | ||
| skip_existing: true | ||
| - stage: test | ||
| name: "Python: 3.8 on Windows" |
Contributor
There was a problem hiding this comment.
I'm a bit confused about name being Python 3.8 on Windows when the os below is osx. What am I missing here?
Contributor
Author
There was a problem hiding this comment.
That is actually two different stages - you were probably looking at the collapsed view in the diff. Does it make more sense when you view the full file?
Contributor
There was a problem hiding this comment.
Oh yes, now I see it. Thanks for adding that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis does not retain any files between different stages (or jobs).
Because the traceability report is generated during the system test stage,
this commit moves the deploy steps into the system test stage where the
file is actually available.