Fix Travis config #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used `tox-travis` to call the correct tox environment (with the correct Python environment) on Travis. However, the macOS and Windows builds did not use the `language: python` setting on Travis. For these builds, tox was called but no tests were executed. This commit explicitly sets TOXENV for all builds in the test stage to ensure that all tests run.
When running the tests locally, we should not attempt to upload coverage information to coveralls: it will fail.
This may be helpful in fixing errors when uploading coverage data of a retried build, according to some discussions on the net.
karthikmswamy
approved these changes
Aug 5, 2020
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Thanks for adding this! Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests were being run on macOS or Windows.