Skip to content

Log with INFO level while waiting for job to succeed #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Log with INFO level while waiting for job to succeed #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aadf1f3
Log with INFO level while waiting for job to succeed
mhaas Aug 4, 2020
e4868de
Update changelog
mhaas Aug 4, 2020
c402235
Merge branch 'master' into feat/improve_logging_job_polling
mhaas Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Documentation: add link to SAP community [#58]
* `ModelCreator.create` performs an initial check if the model name is already used
and raises `ModelAlreadyExists` in this case [#60], [#64]
* `ModelManager.wait_for_job` now logs with level INFO while polling [#66]

### Fixed

Expand All @@ -26,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#60]: https://github.com/SAP/data-attribute-recommendation-python-sdk/issues/60
[#63]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/63
[#64]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/64
[#66]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/66

## [0.6.8]

Expand Down
2 changes: 1 addition & 1 deletion sap/aibus/dar/client/model_manager_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def wait_for_job(self, job_id: str) -> dict:
)

def polling_function():
self.log.debug("Polling for status of job '%s'", job_id)
self.log.info("Polling for status of job '%s'", job_id)
return self.read_job_by_id(job_id)

self.log.info("Waiting for job '%s' to finish.", job_id)
Expand Down