Skip to content

Expose Dataset validationMessage in DatasetValidationFailed #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Expose Dataset validationMessage in DatasetValidationFailed #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77e14ce
Expose Dataset validationMessage in DatasetValidationFailed
mhaas Aug 5, 2020
befcb05
Update CHANGELOG
mhaas Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

* Log message missing model deployment ID [#59]
* Expose a Dataset's `validationMessage` in `DatasetValidationFailed` [#33], [#69]

[#33]: https://github.com/SAP/data-attribute-recommendation-python-sdk/issues/33
[#46]: https://github.com/SAP/data-attribute-recommendation-python-sdk/issues/46
[#58]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/58
[#59]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/59
[#60]: https://github.com/SAP/data-attribute-recommendation-python-sdk/issues/60
[#63]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/63
[#64]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/64
[#66]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/66
[#69]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/69

## [0.6.8]

Expand Down
7 changes: 5 additions & 2 deletions sap/aibus/dar/client/data_manager_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,11 @@ def polling_function() -> dict:
raise new_exception from exception

if self.is_dataset_validation_failed(response):
msg = "Validation for Dataset '{}' failed with status: '{}'".format(
response["id"], response["status"]
msg = (
"Validation for Dataset '{}' failed with status '{}' and"
" validation message: '{}'".format(
response["id"], response["status"], response["validationMessage"]
)
)
self.log.error(msg)
raise DatasetValidationFailed(msg)
Expand Down
9 changes: 7 additions & 2 deletions tests/sap/aibus/dar/client/test_data_manager_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,9 @@ def test_wait_for_validation_raises_if_validation_fails(self):

dataset_response = self._make_dataset_response(bad_dataset_state)

if bad_dataset_state == "VALIDATION_FAILED":
dataset_response["validationMessage"] = "Detailed Description"

client.session.get_from_endpoint.return_value.json.side_effect = [
dataset_response
]
Expand All @@ -466,8 +469,10 @@ def test_wait_for_validation_raises_if_validation_fails(self):
)
expected_message = (
"Validation for Dataset "
"'{}' failed with status: '{}'".format(
dataset_response["id"], bad_dataset_state
"'{}' failed with status '{}' and validation message: '{}'".format(
dataset_response["id"],
bad_dataset_state,
dataset_response["validationMessage"],
)
)

Expand Down