Skip to content

Log job progress in ModelManagerClient.wait_for_job #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Log job progress in ModelManagerClient.wait_for_job #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58fc82e
Log job progress in ModelManagerClient.wait_for_job
mhaas Nov 19, 2020
1e954e7
Update CHANGELOG
mhaas Nov 19, 2020
0638919
Fix link in CHANGELOG
mhaas Nov 19, 2020
a26ed50
Merge branch 'master' into log_job_progress
karthikmswamy Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

[#81] : https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/81

* Log job progress in ModelManagerClient.wait_for_job [#87]

[#87] : https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/87

## [0.7.0]

### Added
Expand Down
9 changes: 8 additions & 1 deletion sap/aibus/dar/client/model_manager_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,14 @@ def wait_for_job(self, job_id: str) -> dict:

def polling_function():
self.log.info("Polling for status of job '%s'", job_id)
return self.read_job_by_id(job_id)
job_resource = self.read_job_by_id(job_id)
self.log.info(
"Job '%s': status '%s', progress: '%s'",
job_id,
job_resource["status"],
job_resource["progress"],
)
return job_resource

self.log.info("Waiting for job '%s' to finish.", job_id)

Expand Down