Construct Client from CloudFoundry service binding #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `BaseClient.construct_from_cf_env`, an instance of the client can be constructed from a service binding on CloudFoundry.
mhaas
force-pushed
the
create_from_cloudfoundry_env
branch
from
2fdef97 to
1f6aded
Compare
karthikmswamy
approved these changes
Jun 10, 2021
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Nice! This looks good. Thanks for adding this.
Was this requested by someone?
karthikmswamy
approved these changes
Jun 10, 2021
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the client can be constructed directly from a service binding (in
VCAP_SERVICES) to the Data Attribute Recommendation service on the SAP Business Technology Platform.