Add support for custom Job and Deployment IDs #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for custom Job and Deployment IDs to be passed to the Data Attribute Recommendation service when creating the respective Job or Deployments. This change is not generally available in the service, but the SDK supports it already. Additionally, this PR updates all dependencies and checks to latest along with any fixes required by these updates.
karthikmswamy
approved these changes
Jun 11, 2021
|
Looks like the Python 3.5 build failed: https://travis-ci.com/github/SAP/data-attribute-recommendation-python-sdk/jobs/513032457 |
|
Hi @karthikmswamy, thanks for checking the build! Python 3.5 is now EOL. I have fixed the build for now. At the same time, I have added a deprecation notice that 3.5 support will be removed eventually. |
|
Thanks for the update, @mhaas! Sounds good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for custom Job and Deployment IDs to be
passed to the Data Attribute Recommendation service when creating
the respective Job or Deployments.
This change is not generally available in the service, but the SDK
supports it already.
Additionally, this PR updates all dependencies and checks to latest
along with any fixes required by these updates.