rm node-18 #56
Merged
rm node-18 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
No more bullseye 🥳 Then we can remove this if for java 11 as well: https://github.com/SAP/devops-docker-node-browsers/pull/56/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R21 |
o-liver
requested changes
Jun 12, 2025
Member
o-liver
left a comment
o-liver
left a comment
There was a problem hiding this comment.
please also remove the if we have for bullseye images
marcusholl
force-pushed
the
marcusholl/pr/rmNode18
branch
from
7c96679 to
eb8a071
Compare
marcusholl
force-pushed
the
marcusholl/pr/rmNode18
branch
from
eb8a071 to
3a05433
Compare
Member
Author
@o-liver : done |
o-liver
approved these changes
Jun 12, 2025
Member
o-liver
left a comment
o-liver
left a comment
There was a problem hiding this comment.
looks good. We keep the rest of the java version logic in case we need it at a future point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side node.18 is rather outdated.