refactor: refactored strategies to use the template design pattern #171
Conversation
| abstract isEnabled(parameters: AppStudioMultiParameters, context: AppStudioMultiContext): boolean; | ||
| } | ||
|
|
||
| export function registerStrategies(appStudioMultiStrategy: AppStudioMultiStrategy): void { |
There was a problem hiding this comment.
This method doesnt feel in the right place.
You define abstract class here for strategy and then comes this specific method which use instances of classes which implement this abstract class.
I would do it as instance method of AppStudioMultiStrategy class.
There was a problem hiding this comment.
AppStudioMultiStrategy is a generic class that should not know the concrete implementation.
unleash_client_manager.ts manage AppStudioMultiStrategy, initialize and register the strategies
| const client = await initializeUnleashClient(extensionName, serverArgs, [new AppStudioMultiStrategy()]); | ||
| const appStudioMultiStrategy = new AppStudioMultiStrategy(); | ||
| const client = await initializeUnleashClient(extensionName, serverArgs, [appStudioMultiStrategy]); | ||
| registerStrategies(appStudioMultiStrategy); |
There was a problem hiding this comment.
I would prefer instance method: appStudioMultiStrategy.registerStrategies()
There was a problem hiding this comment.
AppStudioMultiStrategy is a generic class that should not know the concrete implementation.
unleash_client_manager.ts manage AppStudioMultiStrategy, initialize and register the strategies
| @@ -1,11 +1,14 @@ | |||
| import { expect } from "chai"; | |||
There was a problem hiding this comment.
rename the file to strategy.spec.ts as it is testing several files inside strategy folder
…nto stratRefactoring
…gle-node into stratRefactoring
No description provided.