Feature/issue#90 shellbar #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 6, 2018 16:50
…ion to accept properties instead of markup
CodesOfRa
reviewed
Dec 12, 2018
Contributor
CodesOfRa
left a comment
CodesOfRa
left a comment
There was a problem hiding this comment.
Hi Inna,
You were very fast with this one!!! 🌟
I get some console errors/warnings for line
- 65 it expects className
- 230 it expects a key for the array items in MenuList component
👍
CodesOfRa
approved these changes
Dec 12, 2018
CodesOfRa
reviewed
Dec 13, 2018
Contributor
CodesOfRa
left a comment
CodesOfRa
left a comment
There was a problem hiding this comment.
I spot one more error for key line 190
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
Feature/issue#90 shellbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.