Add methods to use the BTP CLI #5305
Conversation
|
|
…as response format, - additional tests
…n, - enable verbose setting,
Dannick-debug
changed the title
|
So this is a fist step, right? And then in another PR you will introduce the corresponding steps that consume this, or put an option into the cf deploy, and other cf steps, to use btp cli instead of cf cli? |
|
Currently we provide the cf-cli with this docker image: https://github.com/SAP/devops-docker-cf-cli Will you provide a docker image for the btp cli as well, or what is the plan? |
Yes exactly it is the first step. In another PR we will then:
|
Thank you for bringing this up! Currently, our focus is on delivering the essential components in Golang for the BTP CLI. While we aren't providing a Docker image ourselves, team members who utilize these functions or steps will have the ability to create their own custom Docker environment if required. |
I renamed some of the file to lower case 👍🏾 |
| PollInterval int | ||
| } | ||
|
|
||
| type CreateServiceInstanceOptions struct { |
There was a problem hiding this comment.
There seem to be two parameters, "ServiceInstance" and "InstanceName". Are they the same? Could you check if the naming is consistent? Also, in regard to other types.
There was a problem hiding this comment.
Yes they where the same. I removed "ServiceInstance". Thank you for bringing it to my attention.
|
| @param pollInterval : in seconds | ||
| @param negativeCheck : set to false if you whant to check the negation of the response of `cmdCheck` | ||
| */ | ||
| func (e *Executor) RunSync(cmdScript string, cmdCheck string, timeout int, pollInterval int, negativeCheck bool) (err error) { |
There was a problem hiding this comment.
The error in err = e.Run(cmdScript) is unhandled. Also, the loop for time.Since(startTime) < timeoutDuration may not terminate in some conditions, due to
if (negativeCheck && (err != nil)) || (!negativeCheck && (err == nil)) always being false. Maybe the two points are related.
|
Follow-up in a different PR |
3 participants
Pull Request Description
Objective
This pull request introduces functions to facilitate the use of the BTP CLI. The key functionalities added include:
Key Improvements
CommandBuilderhas been developed to streamline script creation, ensuring efficient command handling.Run): Enables concurrent task execution without blocking the main process.RunSync): Incorporates a polling mechanism to verify the success of BTP actions at regular intervals.Synchronous Execution
Currently, BTP actions do not support direct synchronous execution. To address this, a
polling mechanismhas been implemented to continuously check the status of actions, ensuring they are completed successfully.Checklist