client: correctly detect MIME #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I didn't expect that metadata will be send in anything else that ASCII. But we absolutely need to know the charse because of labels. Northwind returns "Content-Type: application/xml;charset=utf-8" Closes SAP#1
jfilak
force-pushed
the
fix_mime_type_metadata
branch
from
31f1d07 to
ffedc82
Compare
Contributor
|
Simple & Looks good. |
phanak-sap
approved these changes
Mar 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't expect that metadata will be sent in anything else that ASCII.
But we absolutely need to know the charset because of labels.
Northwind returns "Content-Type: application/xml;charset=utf-8"
Closes #7