Skip to content

Conversation

@sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Dec 12, 2018

Themes should also build if there is an librariesPattern provided but no library found

Fixes: #110

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

Themes should also build if there is an librariesPattern provided but no library found

Fixes: #110
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2018

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Dec 12, 2018

Pull Request Test Coverage Report for Build 493

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 53.741%

Totals Coverage Status
Change from base Build 491: 0.5%
Covered Lines: 1489
Relevant Lines: 2506

💛 - Coveralls

added tests for theme build without library
@RandomByte
Copy link
Member

Thanks @sebbi08!

LGTM. @matz3 what do you think?

Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matz3 also agrees with this change 😃

We'll release this today. Thanks again!

@RandomByte RandomByte merged commit 528e1c0 into SAP:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants