Skip to content

Conversation

@RandomByte
Copy link
Member

Temporary fix preventing '*-dbg' files from being included in preload
bundles.

Resolves #12 for the time being

@RandomByte RandomByte added the bug label Jun 20, 2018
@RandomByte RandomByte requested review from codeworrior and matz3 June 20, 2018 15:58
@coveralls
Copy link

coveralls commented Jun 20, 2018

Pull Request Test Coverage Report for Build 149

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 62.864%

Totals Coverage Status
Change from base Build 130: 0.2%
Covered Lines: 425
Relevant Lines: 620

💛 - Coveralls

@RandomByte
Copy link
Member Author

CC @stopcoder: does this resolve your requirement for the core-min bundle as well?

@RandomByte RandomByte force-pushed the no-dbg-in-preloads branch from c8f652b to 47b09e5 Compare June 20, 2018 16:04
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Temporary fix preventing '*-dbg' files from being included in preload
bundles.

Resolves #12 for the time being
@RandomByte RandomByte force-pushed the no-dbg-in-preloads branch from 47b09e5 to 13385d2 Compare June 20, 2018 16:33
@RandomByte RandomByte merged commit 19800a1 into master Jun 21, 2018
@RandomByte RandomByte deleted the no-dbg-in-preloads branch June 21, 2018 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundles contain minified and dbg files

5 participants