Skip to content

[INTERNAL] use eslint-plugin-ava and cleanup test-suite #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

[INTERNAL] use eslint-plugin-ava and cleanup test-suite #395

merged 1 commit into from
Aug 19, 2022

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Aug 18, 2022 •
edited
Loading

Introducing eslint-plugin-ava to avoid common pitfalls when writing powerful ava tests.

  • Add plugin to eslint config and package.json
  • Restructure current code base to latest recommendations

@flovogt flovogt requested a review from matz3 August 18, 2022 13:05
@coveralls
Copy link

coveralls commented Aug 18, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 87.312% when pulling 79db6c7 on eslint-ava into 636acd4 on next.

matz3
matz3 previously approved these changes Aug 19, 2022
View reviewed changes
flovogt
flovogt commented Aug 19, 2022
View reviewed changes
@flovogt flovogt merged commit a18fc04 into next Aug 19, 2022
@flovogt flovogt deleted the eslint-ava branch August 19, 2022 11:52
@flovogt flovogt mentioned this pull request Sep 12, 2022
Closed
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 25, 2025
@flovogt
[fs][INTERNAL] use eslint-plugin-ava and clean up test-suite (SAP/ui5…
4c5a2a1 
…-fs#395)
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 26, 2025
@flovogt @d3xter666
[fs][INTERNAL] use eslint-plugin-ava and clean up test-suite (SAP/ui5…
a5f4a91 
…-fs#395)
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 26, 2025
@flovogt @d3xter666
[fs][INTERNAL] use eslint-plugin-ava and clean up test-suite (SAP/ui5…
419003a 
…-fs#395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matz3 matz3 matz3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flovogt @coveralls @matz3