Skip to content

Conversation

@matz3
Copy link
Member

@matz3 matz3 commented Feb 7, 2025

Switching from just a Program to the LanguageService has several benefits:

  • Adding/changing source files is possible without having to create a new program manually while keeping all unchanged files cached
  • Host implementation is more lightweight
  • A shared LanguageService can be used to improve performance when linting multiple independent files/projects within the same process/thread. This is currently only used internally by the tests, but a new public API can be easily provided.

d3xter666
d3xter666 previously approved these changes Feb 7, 2025
Copy link
Member

@d3xter666 d3xter666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 force-pushed the refactor-ts-language-service branch from b5a215d to e7f4f2c Compare February 7, 2025 14:10
@matz3
Copy link
Member Author

matz3 commented Feb 7, 2025

Ready for review 👍🏻

@matz3 matz3 merged commit 85db5fa into main Feb 7, 2025
15 checks passed
@matz3 matz3 deleted the refactor-ts-language-service branch February 7, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants