fix: XML namespace handling #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
fix-xml-namespace-handling
branch
from
aeb0223 to
d78c225
Compare
codeworrior
previously approved these changes
Feb 28, 2025
src/linter/xmlTemplate/Parser.ts
Outdated
| localName: null, | ||
| namespace: attrValue, | ||
| }, this.#nodeStack.length); | ||
| }, this.#nodeStack.length + 1); // +1 as the currently created node is not yet on the stack |
Member
There was a problem hiding this comment.
if the idea is that level counts from 1, I'm fine with this change.- Alternatively, if level should correspond to the node's position in the #nodeStack, popTag could just remove level - 1(or swap L171 and L172 and adapt the constant in L178).
Member
Author
There was a problem hiding this comment.
Thanks. That's a way better solution.
The stack of XML namespaces was not being properly maintained which resulted into wrong assumptions about controls in some scenarios when multiple default namespaces were present in the XML.
matz3
force-pushed
the
fix-xml-namespace-handling
branch
from
d78c225 to
68f12c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack of XML namespaces was not being properly maintained which
resulted into wrong assumptions about controls in some scenarios when
multiple default namespaces were present in the XML.