Skip to content

Commit 07401f2

Browse files
kgogovkgogov
committed
Merge branch 'main' into feat-list-wrapping
2 parents 166940b + e64c124 commit 07401f2

File tree

154 files changed

+4823
-1338
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

154 files changed

+4823
-1338
lines changed

‎CHANGELOG.md‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,42 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
# [2.9.0-rc.1](https://github.com/SAP/ui5-webcomponents/compare/v2.9.0-rc.0...v2.9.0-rc.1) (2025-03-20)
7+
8+
9+
### Bug Fixes
10+
11+
* keep export paths in base in sync ([#11082](https://github.com/SAP/ui5-webcomponents/issues/11082)) ([8620ac8](https://github.com/SAP/ui5-webcomponents/commit/8620ac8823256ecf34ba70b4c06210253a3e5d14))
12+
* **tools:** fix icon imports to i18n texts ([#11091](https://github.com/SAP/ui5-webcomponents/issues/11091)) ([472ffdc](https://github.com/SAP/ui5-webcomponents/commit/472ffdcd602a4da53a839829e5a5bcf017ff618c))
13+
* **ui5-carousel:** fix typo mistake ([#11107](https://github.com/SAP/ui5-webcomponents/issues/11107)) ([e23f746](https://github.com/SAP/ui5-webcomponents/commit/e23f746bca7b858b92b15d1d4903432d65289422)), closes [#11032](https://github.com/SAP/ui5-webcomponents/issues/11032)
14+
* **ui5-combobox:** properly navigate with arrow down keys ([#11097](https://github.com/SAP/ui5-webcomponents/issues/11097)) ([967ef56](https://github.com/SAP/ui5-webcomponents/commit/967ef56962aa9f341305ed00a09177d62405a785)), closes [#11029](https://github.com/SAP/ui5-webcomponents/issues/11029)
15+
* **ui5-input:** fire input event on escape key ([#11079](https://github.com/SAP/ui5-webcomponents/issues/11079)) ([8b85288](https://github.com/SAP/ui5-webcomponents/commit/8b852881dd9364216f5051b587f2e7e5102b4945)), closes [#11021](https://github.com/SAP/ui5-webcomponents/issues/11021)
16+
* **ui5-li:** announce active state ([#11064](https://github.com/SAP/ui5-webcomponents/issues/11064)) ([b6b70a9](https://github.com/SAP/ui5-webcomponents/commit/b6b70a9f8ab2a78bceb0a8bca8ed2c12c63ea13d))
17+
* **ui5-list-item-group-header:** typo fixed ([#11100](https://github.com/SAP/ui5-webcomponents/issues/11100)) ([e8af105](https://github.com/SAP/ui5-webcomponents/commit/e8af1059d118fc77dcaef0b7dd7012ad406fde7a))
18+
* **ui5-menu-item:** remove dot from class ([#11119](https://github.com/SAP/ui5-webcomponents/issues/11119)) ([66bedb4](https://github.com/SAP/ui5-webcomponents/commit/66bedb421036af054cfc45a512953342f9917cdb)), closes [#11043](https://github.com/SAP/ui5-webcomponents/issues/11043)
19+
* **ui5-menu:** fix menu item type fix ([#11129](https://github.com/SAP/ui5-webcomponents/issues/11129)) ([3e68c57](https://github.com/SAP/ui5-webcomponents/commit/3e68c576fb9a577e51acf99e0608691b15b213fb)), closes [#10933](https://github.com/SAP/ui5-webcomponents/issues/10933)
20+
* **ui5-multi-combobox:** fix deletion of long tokens ([#11080](https://github.com/SAP/ui5-webcomponents/issues/11080)) ([5c6d746](https://github.com/SAP/ui5-webcomponents/commit/5c6d746b2354acc09172a53b0a1507ab3ff4458e)), closes [#10977](https://github.com/SAP/ui5-webcomponents/issues/10977)
21+
* **ui5-multiinput:** correct failing test ([#11111](https://github.com/SAP/ui5-webcomponents/issues/11111)) ([b30330d](https://github.com/SAP/ui5-webcomponents/commit/b30330d38ae574f628611f21b9078ee98df7b592))
22+
* **ui5-shellbar:** fix separators visibility when items are hidden ([#11058](https://github.com/SAP/ui5-webcomponents/issues/11058)) ([d721e87](https://github.com/SAP/ui5-webcomponents/commit/d721e87263313f34783636cb65aa325c18257ef6))
23+
* **ui5-shellbar:** sap home no longer hard coded in title readings ([#11034](https://github.com/SAP/ui5-webcomponents/issues/11034)) ([2810da6](https://github.com/SAP/ui5-webcomponents/commit/2810da6c54dc099eb693a804adfa7a6bb9d26048)), closes [#10970](https://github.com/SAP/ui5-webcomponents/issues/10970)
24+
* **ui5-table:** focus visiblity (compat) ([#11118](https://github.com/SAP/ui5-webcomponents/issues/11118)) ([d99ab42](https://github.com/SAP/ui5-webcomponents/commit/d99ab4232dc3ea49eb1edc8770aba58e8d753321)), closes [#11112](https://github.com/SAP/ui5-webcomponents/issues/11112)
25+
* **ui5-tag:** fix click event ([#11102](https://github.com/SAP/ui5-webcomponents/issues/11102)) ([3eec3bb](https://github.com/SAP/ui5-webcomponents/commit/3eec3bbbfc2fcaf6a5b4c6e70c7fcb7cd7e1bcec)), closes [#11096](https://github.com/SAP/ui5-webcomponents/issues/11096)
26+
27+
28+
### Features
29+
30+
* **ui5-input:** support accessible description ([#10821](https://github.com/SAP/ui5-webcomponents/issues/10821)) ([410f4d2](https://github.com/SAP/ui5-webcomponents/commit/410f4d2fbc2f62742e419e437824a435c79fc6ef)), closes [#10131](https://github.com/SAP/ui5-webcomponents/issues/10131)
31+
* **ui5-search:** introduce experimental component ([#11125](https://github.com/SAP/ui5-webcomponents/issues/11125)) ([48f16fb](https://github.com/SAP/ui5-webcomponents/commit/48f16fb1d05957b3779aeb4868f3cebe5cac5bc2))
32+
* **ui5-select:** "icon" property introduced ([#11060](https://github.com/SAP/ui5-webcomponents/issues/11060)) ([0b242e3](https://github.com/SAP/ui5-webcomponents/commit/0b242e3e0e6d7c03dcbebd4fc798338627ebeb09)), closes [#10859](https://github.com/SAP/ui5-webcomponents/issues/10859)
33+
* **ui5-shellbar:** accessibility attributes added to action buttons ([#10951](https://github.com/SAP/ui5-webcomponents/issues/10951)) ([c8c3e19](https://github.com/SAP/ui5-webcomponents/commit/c8c3e1941ab98c02ffa97c4a700d38619cb0326f))
34+
* **ui5-side-navigation:** enable the web component in popover placement ([#10701](https://github.com/SAP/ui5-webcomponents/issues/10701)) ([a4565fe](https://github.com/SAP/ui5-webcomponents/commit/a4565fe3a3ecb5a3d150942ed72faabbbc770b4a))
35+
* **ui5-side-navigation:** update visual design ([#11046](https://github.com/SAP/ui5-webcomponents/issues/11046)) ([b5d83a8](https://github.com/SAP/ui5-webcomponents/commit/b5d83a8a0bab9a18d796d9a9515f8e9b5a47c38f))
36+
* **ui5-user-menu:** design enhancements ([#11124](https://github.com/SAP/ui5-webcomponents/issues/11124)) ([5164035](https://github.com/SAP/ui5-webcomponents/commit/516403532ac4fd0e1c12ca2c4ad79c4091f615ca))
37+
38+
39+
40+
41+
642
# [2.9.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.8.1-rc.0...v2.9.0-rc.0) (2025-03-13)
743

844

‎docs/2-advanced/09-accessibility.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ Will result in the shadow DOM as:
209209
The `accessibleDescription` property is currently supported in:
210210
* [List](https://sap.github.io/ui5-webcomponents/nightly/components/List/)
211211
* [Tree](https://sap.github.io/ui5-webcomponents/nightly/components/Tree/)
212+
* [Input](https://sap.github.io/ui5-webcomponents/nightly/components/Input/)
212213

213214
---
214215

@@ -233,6 +234,7 @@ Will result in the shadow DOM as:
233234
The `accessibleDescriptionRef` property is currently supported in:
234235
* [List](https://sap.github.io/ui5-webcomponents/nightly/components/List/)
235236
* [Tree](https://sap.github.io/ui5-webcomponents/nightly/components/Tree/)
237+
* [Input](https://sap.github.io/ui5-webcomponents/nightly/components/Input/)
236238

237239
---
238240

‎lerna.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"packages/create-package",
1515
"packages/compat"
1616
],
17-
"version": "2.9.0-rc.0",
17+
"version": "2.9.0-rc.1",
1818
"command": {
1919
"publish": {
2020
"allowBranch": "*",

‎packages/ai/CHANGELOG.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
# [2.9.0-rc.1](https://github.com/SAP/ui5-webcomponents/compare/v2.9.0-rc.0...v2.9.0-rc.1) (2025-03-20)
7+
8+
**Note:** Version bump only for package @ui5/webcomponents-ai
9+
10+
11+
12+
13+
614
# [2.9.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.8.1-rc.0...v2.9.0-rc.0) (2025-03-13)
715

816
**Note:** Version bump only for package @ui5/webcomponents-ai

‎packages/ai/package.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ui5/webcomponents-ai",
3-
"version": "2.9.0-rc.0",
3+
"version": "2.9.0-rc.1",
44
"description": "UI5 Web Components: webcomponents.ai",
55
"ui5": {
66
"webComponentsPackage": true
@@ -48,14 +48,14 @@
4848
"directory": "packages/ai"
4949
},
5050
"dependencies": {
51-
"@ui5/webcomponents": "2.9.0-rc.0",
52-
"@ui5/webcomponents-base": "2.9.0-rc.0",
53-
"@ui5/webcomponents-icons": "2.9.0-rc.0",
54-
"@ui5/webcomponents-theming": "2.9.0-rc.0"
51+
"@ui5/webcomponents": "2.9.0-rc.1",
52+
"@ui5/webcomponents-base": "2.9.0-rc.1",
53+
"@ui5/webcomponents-icons": "2.9.0-rc.1",
54+
"@ui5/webcomponents-theming": "2.9.0-rc.1"
5555
},
5656
"devDependencies": {
5757
"@ui5/cypress-internal": "0.0.0",
58-
"@ui5/webcomponents-tools": "2.9.0-rc.0",
58+
"@ui5/webcomponents-tools": "2.9.0-rc.1",
5959
"chromedriver": "^133.0.0"
6060
}
6161
}

‎packages/base/CHANGELOG.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,17 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
# [2.9.0-rc.1](https://github.com/SAP/ui5-webcomponents/compare/v2.9.0-rc.0...v2.9.0-rc.1) (2025-03-20)
7+
8+
9+
### Bug Fixes
10+
11+
* keep export paths in base in sync ([#11082](https://github.com/SAP/ui5-webcomponents/issues/11082)) ([8620ac8](https://github.com/SAP/ui5-webcomponents/commit/8620ac8823256ecf34ba70b4c06210253a3e5d14))
12+
13+
14+
15+
16+
617
# [2.9.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.8.1-rc.0...v2.9.0-rc.0) (2025-03-13)
718

819

‎packages/base/cypress/specs/util/FocusableElements.cy.tsx‎

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
import { getFirstFocusableElement } from "@ui5/webcomponents-base/dist/util/FocusableElements.js";
2+
import SideNavigation from "@ui5/webcomponents-fiori/dist/SideNavigation.js";
3+
import SideNavigationItem from "@ui5/webcomponents-fiori/dist/SideNavigationItem.js";
4+
import SideNavigationSubItem from "@ui5/webcomponents-fiori/dist/SideNavigationSubItem.js";
5+
import Button from "@ui5/webcomponents/dist/Button.js";
6+
import Input from "@ui5/webcomponents/dist/Input.js";
7+
8+
describe("FocusableElements", () => {
9+
it("Tests first focusable element", () => {
10+
cy.mount(
11+
<>
12+
<div id="container">
13+
<Input tabindex="-1"></Input>
14+
<br/>
15+
<SideNavigation>
16+
<SideNavigationItem
17+
text="Home"
18+
icon="home"
19+
href="#home"
20+
title="Home tooltip"></SideNavigationItem>
21+
<SideNavigationItem text="People" href="#people" expanded icon="group">
22+
<SideNavigationSubItem
23+
id="subItem1"
24+
selected
25+
text="Should be Focused When Open"></SideNavigationSubItem>
26+
<SideNavigationSubItem text="Sub Item 2"></SideNavigationSubItem>
27+
</SideNavigationItem>
28+
</SideNavigation>
29+
<br/>
30+
<Button id="buttonId">Close</Button>
31+
</div>
32+
</>
33+
);
34+
35+
cy.get("#subItem1")
36+
.shadow()
37+
.find(".ui5-sn-item")
38+
.should("have.attr", "tabindex", "0");
39+
40+
cy.get("#container").then( async ($container) => {
41+
const firstFocusable = await getFirstFocusableElement($container.get(0));
42+
await firstFocusable?.focus();
43+
});
44+
45+
cy.get("#subItem1")
46+
.should("have.focus");
47+
});
48+
});

‎packages/base/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ui5/webcomponents-base",
3-
"version": "2.9.0-rc.0",
3+
"version": "2.9.0-rc.1",
44
"description": "UI5 Web Components: webcomponents.base",
55
"author": "SAP SE (https://www.sap.com)",
66
"license": "Apache-2.0",
@@ -62,7 +62,7 @@
6262
"devDependencies": {
6363
"@openui5/sap.ui.core": "1.120.17",
6464
"@ui5/cypress-internal": "0.0.0",
65-
"@ui5/webcomponents-tools": "2.9.0-rc.0",
65+
"@ui5/webcomponents-tools": "2.9.0-rc.1",
6666
"chromedriver": "^133.0.0",
6767
"clean-css": "^5.2.2",
6868
"copy-and-watch": "^0.1.5",

‎packages/base/src/util/FocusableElements.ts‎

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,17 @@ const isElemFocusable = (el: HTMLElement) => {
3636
return el.hasAttribute("data-ui5-focus-redirect") || !isElementHidden(el);
3737
};
3838

39+
const isUI5ElementWithNegativeTabIndex = (el: HTMLElement) => {
40+
if (instanceOfUI5Element(el)) {
41+
const tabIndex = el.getAttribute("tabindex");
42+
if (tabIndex !== null && parseInt(tabIndex) < 0) {
43+
return true;
44+
}
45+
}
46+
47+
return false;
48+
};
49+
3950
const findFocusableElement = async (container: HTMLElement, forward: boolean, startFromContainer?: boolean): FocusableElementPromise => {
4051
let child: HTMLElement | undefined;
4152
let assignedElements;
@@ -60,9 +71,16 @@ const findFocusableElement = async (container: HTMLElement, forward: boolean, st
6071
while (child) {
6172
const originalChild: HTMLElement | undefined = child;
6273

63-
if (!isElementHidden(originalChild)) {
74+
if (!isElementHidden(originalChild) && !isUI5ElementWithNegativeTabIndex(originalChild)) {
6475
if (instanceOfUI5Element(child)) {
65-
child = await child.getFocusDomRefAsync();
76+
// getDomRef is used because some components mark their focusable ref in an inner
77+
// html but there might also be focusable targets outside of it
78+
// as an example - TreeItemBase
79+
// div - root of the component returned by getDomRef()
80+
// li.ui5-li-tree - returned by getFocusDomRef() and may not be focusable (ItemNavigation manages tabindex)
81+
// ul.subtree - may still contain focusable targets (sub nodes of the tree item)
82+
await child._waitForDomRef();
83+
child = child.getDomRef();
6684
}
6785

6886
if (!child || isElementHidden(child)) {

‎packages/compat/CHANGELOG.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,17 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
# [2.9.0-rc.1](https://github.com/SAP/ui5-webcomponents/compare/v2.9.0-rc.0...v2.9.0-rc.1) (2025-03-20)
7+
8+
9+
### Bug Fixes
10+
11+
* **ui5-table:** focus visiblity (compat) ([#11118](https://github.com/SAP/ui5-webcomponents/issues/11118)) ([d99ab42](https://github.com/SAP/ui5-webcomponents/commit/d99ab4232dc3ea49eb1edc8770aba58e8d753321)), closes [#11112](https://github.com/SAP/ui5-webcomponents/issues/11112)
12+
13+
14+
15+
16+
617
# [2.9.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.8.1-rc.0...v2.9.0-rc.0) (2025-03-13)
718

819
**Note:** Version bump only for package @ui5/webcomponents-compat

0 commit comments

Comments
 (0)