build drivers and self building #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikonse
force-pushed
the
milo/build-drivers-and-self-building
branch
from
6478f71 to
f066493
Compare
TheJJ
requested changes
Nov 23, 2025
| from pathlib import Path | ||
| from typing import Literal, Sequence | ||
|
|
||
| BuildDriverType = Literal["docker"] | Literal["lxd"] | Literal["none"] |
src/debmagic/_build_driver/build.py
Outdated
|
|
||
| # TODO: copy packages to output directory | ||
| config.output_dir.mkdir(parents=True, exist_ok=True) | ||
| driver.copy_file(source_dir=config.source_dir / "..", glob="debmagic_*.deb", dest_dir=config.output_dir) |
Member
There was a problem hiding this comment.
why debmagic_ prefix? output should be the regular deb, no?
| pass | ||
|
|
||
| def drop_into_shell(self): | ||
| run_cmd_in_foreground(["/usr/bin/env", "bash"]) |
Member
There was a problem hiding this comment.
while this makes sense (maybe use the user/root's shell in the build env instead of bash?), i think a shell manages the foreground run itself. i would still leave it, though.
| print( | ||
| "Something failed during building - dropping into interactive shell in build environment for easier debugging" | ||
| ) | ||
| driver.drop_into_shell() |
Member
There was a problem hiding this comment.
a way to get into the build (and stop it at/after/... arbitrary stages) directly would be very handy
| return instance | ||
|
|
||
| def run_command(self, args: Sequence[str | Path], cwd: Path | None = None, requires_root: bool = False): | ||
| del requires_root # we assume to always be root in the container |
Member
There was a problem hiding this comment.
maybe run stuff as id1000 unless requires_root is true, for consistency and checking of procedures in drivers that do need the difference?
| def copy_file(self, source_dir: Path, glob: str, dest_dir: Path): | ||
| translated_source = self._translate_source_path(source_dir) | ||
| translated_output = self._translate_output_path(dest_dir) | ||
| self.run_command(["/usr/bin/env", "bash", "-c", f"cp -f {translated_source}/{glob} {translated_output}"]) |
Member
There was a problem hiding this comment.
we could have a shell=True for run_command, run_cmd supports this anyway.
mikonse
force-pushed
the
milo/build-drivers-and-self-building
branch
from
f066493 to
08ead93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1