Core work8 #20
Open
Core work8 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/ru/skypro/Main.java
# Conflicts: # src/ru/skypro/Main.java
iStemmer
reviewed
Oct 26, 2022
src/ru/skypro/products/Tovar.java
Outdated
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class Tovar { |
iStemmer
reviewed
Nov 7, 2022
src/ru/skypro/transport/DriverD.java
Outdated
| import ru.skypro.exceptions.WrongRightsException; | ||
|
|
||
| public class DriverD extends Driver{ | ||
| public DriverD(String fio, Boolean haveRights, Integer stazh, Bus transport) throws WrongRightsException { |
iStemmer
reviewed
Nov 7, 2022
|
|
||
| private List<Mechanic> mechanicList = new ArrayList<>(); | ||
|
|
||
| private Driver driver; |
There was a problem hiding this comment.
тут должен быть список всех всех потенциальных водетелей
iStemmer
reviewed
Nov 7, 2022
src/ru/skypro/products/Recept.java
Outdated
|
|
||
| Set<Product> setProducts = new HashSet<>(); | ||
| private final String name; | ||
| public Integer SumCostProducts(){ |
There was a problem hiding this comment.
SumCostProducts - метод большой буквы. lowerCamelCase
iStemmer
reviewed
Nov 7, 2022
src/ru/skypro/products/Recept.java
Outdated
| } | ||
|
|
||
| public void addToSet(Product val){ | ||
| setProducts.add(val); |
There was a problem hiding this comment.
проверка на то, что такой продукт существует?
iStemmer
reviewed
Nov 7, 2022
src/ru/skypro/products/Product.java
Outdated
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (!(o instanceof Product product)) return false; | ||
| return Objects.equals(cost, product.cost) && Objects.equals(weight, product.weight); |
There was a problem hiding this comment.
сравнение по цене? Мне кажется это неправильно.
iStemmer
reviewed
Nov 7, 2022
src/ru/skypro/Main.java
Outdated
| Random r = new Random(); | ||
| int int1 = r.nextInt(7)+2; | ||
| int int2 = r.nextInt(7)+2; | ||
| uniqueQuestion.add(int1 + "*" + int2); |
There was a problem hiding this comment.
нет проверки на зеркальные примеры, например 34 и 43
iStemmer
reviewed
Nov 24, 2022
| Random r = new Random(); | ||
| int int1 = r.nextInt(7)+2; | ||
| int int2 = r.nextInt(7)+2; | ||
| if (!uniqueQuestion.contains(int2 + "*" + int1)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.