Pull from main to branch #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve INSPIRE citekey handling and cleanup
- Implement retry mechanism with 3 attempts and exponential backoff - Add timeout configuration (10s connect, 30s read) - Add comprehensive logging (INFO/WARN/DEBUG levels) - Add citation key validation to detect URL-like keys - Improve error messages with actionable suggestions - Add test guide for validation Part of issue JabRef#12292 - Task 3.2: INSPIRE API optimization Provides stable data source for other team members' tasks
- Integrated Sonia's 3.1 task (texkeys extraction and key cleanup) - Kept retry mechanism and validation from 3.2 task - Combined both features for complete INSPIRE fetcher improvement - Removed test documentation file
- Import java.time.Duration for timeout settings - Use Duration.ofMillis() for setConnectTimeout (URLDownload only supports connect timeout) - Remove setReadTimeout (not supported by URLDownload class) - Change catch block to ParseException | FetcherException (IOException not thrown) - Code now compiles successfully
feat(3.2): Add retry mechanism and validation to INSPIRE fetcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull from main to branch-sonia-inspirefetcher