Skip to content
This repository was archived by the owner on Sep 3, 2024. It is now read-only.

Commit 9fe6481

Browse files
thefringeninjathefringeninja
committed
remove some magic strings
1 parent 1a15ba1 commit 9fe6481

File tree

8 files changed

+29
-29
lines changed

8 files changed

+29
-29
lines changed

‎src/SqlStreamStore.HAL.Tests/ClientErrorTests.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,27 +43,27 @@ private static readonly (string requestUri, MediaTypeWithQualityHeaderValue[] no
4343
HttpMethod.Get,
4444
HttpMethod.Head
4545
}),
46-
("/streams/a-stream", new[] { s_TextMarkdown, s_TextPlain }, new[]
46+
($"/{Constants.Streams.Stream}/a-stream", new[] { s_TextMarkdown, s_TextPlain }, new[]
4747
{
4848
HttpMethod.Get,
4949
HttpMethod.Head,
5050
HttpMethod.Post,
5151
HttpMethod.Delete
5252
}),
53-
("/streams/a-stream/0", new[] { s_TextMarkdown, s_TextPlain }, new[]
53+
($"/{Constants.Streams.Stream}/a-stream/0", new[] { s_TextMarkdown, s_TextPlain }, new[]
5454
{
5555
HttpMethod.Get,
5656
HttpMethod.Head,
5757
HttpMethod.Delete
5858
}),
59-
($"/streams/a-stream/{Guid.Empty}", new[] { s_TextMarkdown, s_TextPlain }, new[]
59+
($"/{Constants.Streams.Stream}/a-stream/{Guid.Empty}", new[] { s_TextMarkdown, s_TextPlain }, new[]
6060
{
6161
HttpMethod.Get,
6262
HttpMethod.Head,
6363
HttpMethod.Delete
6464
}),
6565

66-
("/streams/a-stream/metadata", new[] { s_TextMarkdown, s_TextPlain }, new[]
66+
($"/{Constants.Streams.Stream}/a-stream/metadata", new[] { s_TextMarkdown, s_TextPlain }, new[]
6767
{
6868
HttpMethod.Get,
6969
HttpMethod.Head,

‎src/SqlStreamStore.HAL.Tests/ConditionalRequestTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ public static IEnumerable<object[]> IfNoneMatchCases()
3030
};
3131
yield return new object[]
3232
{
33-
$"/streams/{streamId}",
33+
$"/{Constants.Streams.Stream}/{streamId}",
3434
new Func<IStreamStore, Task>(
3535
streamStore => streamStore.AppendToStream(streamId, ExpectedVersion.NoStream, message))
3636
};
3737
yield return new object[]
3838
{
39-
$"/streams/{streamId}/metadata",
39+
$"/{Constants.Streams.Stream}/{streamId}/metadata",
4040
new Func<IStreamStore, Task>(
4141
streamStore => streamStore.SetStreamMetadata(streamId, ExpectedVersion.NoStream, 1))
4242
};

‎src/SqlStreamStore.HAL.Tests/OptionsTests.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,25 +36,25 @@ public static IEnumerable<object[]> OptionsAllowedMethodCases()
3636

3737
yield return new object[]
3838
{
39-
"/streams/a-stream",
39+
$"/{Constants.Streams.Stream}/a-stream",
4040
new[] { HttpMethod.Get, HttpMethod.Head, HttpMethod.Options, HttpMethod.Delete, HttpMethod.Post }
4141
};
4242

4343
yield return new object[]
4444
{
45-
"/streams/a-stream/0",
45+
$"/{Constants.Streams.Stream}/a-stream/0",
4646
new[] { HttpMethod.Get, HttpMethod.Head, HttpMethod.Delete, HttpMethod.Options }
4747
};
4848

4949
yield return new object[]
5050
{
51-
$"/streams/a-stream/{Guid.Empty}",
51+
$"/{Constants.Streams.Stream}/a-stream/{Guid.Empty}",
5252
new[] { HttpMethod.Get, HttpMethod.Head, HttpMethod.Delete, HttpMethod.Options }
5353
};
5454

5555
yield return new object[]
5656
{
57-
"/streams/a-stream/metadata",
57+
$"/{Constants.Streams.Stream}/a-stream/metadata",
5858
new[] { HttpMethod.Get, HttpMethod.Head, HttpMethod.Post, HttpMethod.Options }
5959
};
6060

‎src/SqlStreamStore.HAL.Tests/StreamAppendTests.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public async Task wrong_expected_version(int[] expectedVersions)
160160
for(var i = 0; i < expectedVersions.Length - 1; i++)
161161
{
162162
using(await _fixture.HttpClient.SendAsync(
163-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}")
163+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}")
164164
{
165165
Headers =
166166
{
@@ -184,7 +184,7 @@ public async Task wrong_expected_version(int[] expectedVersions)
184184
}
185185

186186
using(var response = await _fixture.HttpClient.SendAsync(
187-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}")
187+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}")
188188
{
189189
Headers =
190190
{
@@ -268,7 +268,7 @@ public static IEnumerable<object[]> MalformedRequestCases()
268268
public async Task malformed_request_body(string malformedRequest)
269269
{
270270
using(var response = await _fixture.HttpClient.SendAsync(
271-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}")
271+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}")
272272
{
273273
Content = new StringContent(malformedRequest)
274274
{
@@ -297,7 +297,7 @@ public static IEnumerable<object[]> BadExpectedVersionCases()
297297
public async Task bad_expected_version(int badExpectedVersion)
298298
{
299299
using(var response = await _fixture.HttpClient.SendAsync(
300-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}")
300+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}")
301301
{
302302
Headers =
303303
{

‎src/SqlStreamStore.HAL.Tests/StreamDeleteTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public async Task expected_version(int? expectedVersion)
2424
{
2525
await _fixture.WriteNMessages(StreamId, 1);
2626

27-
var request = new HttpRequestMessage(HttpMethod.Delete, $"/streams/{StreamId}");
27+
var request = new HttpRequestMessage(HttpMethod.Delete, $"/{Constants.Streams.Stream}/{StreamId}");
2828

2929
if(expectedVersion.HasValue)
3030
{
@@ -47,7 +47,7 @@ public async Task expected_version(int? expectedVersion)
4747
public async Task wrong_expected_version(int expectedVersion)
4848
{
4949
await _fixture.WriteNMessages(StreamId, 1);
50-
var request = new HttpRequestMessage(HttpMethod.Delete, $"/streams/{StreamId}")
50+
var request = new HttpRequestMessage(HttpMethod.Delete, $"/{Constants.Streams.Stream}/{StreamId}")
5151
{
5252
Headers =
5353
{

‎src/SqlStreamStore.HAL.Tests/StreamMessageTests.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public async Task read_single_message_stream()
2424
{
2525
var writeResult = await _fixture.WriteNMessages("a-stream", 1);
2626

27-
using(var response = await _fixture.HttpClient.GetAsync("/streams/a-stream/0"))
27+
using(var response = await _fixture.HttpClient.GetAsync($"/{Constants.Streams.Stream}/a-stream/0"))
2828
{
2929
response.StatusCode.ShouldBe(HttpStatusCode.OK);
3030
response.Headers.ETag.ShouldBe(new EntityTagHeaderValue($@"""{writeResult.CurrentVersion}"""));
@@ -47,7 +47,7 @@ public async Task read_single_message_stream()
4747
[Fact]
4848
public async Task read_single_message_does_not_exist_stream()
4949
{
50-
using(var response = await _fixture.HttpClient.GetAsync("/streams/a-stream/0"))
50+
using(var response = await _fixture.HttpClient.GetAsync($"/{Constants.Streams.Stream}/a-stream/0"))
5151
{
5252
response.StatusCode.ShouldBe(HttpStatusCode.NotFound);
5353
response.Headers.ETag.ShouldBeNull();
@@ -71,14 +71,14 @@ public async Task delete_single_message_by_version()
7171
{
7272
var writeResult = await _fixture.WriteNMessages("a-stream", 1);
7373

74-
using(var response = await _fixture.HttpClient.DeleteAsync("/streams/a-stream/0"))
74+
using(var response = await _fixture.HttpClient.DeleteAsync($"/{Constants.Streams.Stream}/a-stream/0"))
7575
{
7676
response.StatusCode.ShouldBe(HttpStatusCode.NoContent);
7777
response.Content.Headers.ContentLength.HasValue.ShouldBeTrue();
7878
response.Content.Headers.ContentLength.Value.ShouldBe(0);
7979
}
8080

81-
using(var response = await _fixture.HttpClient.GetAsync("/streams/a-stream/0"))
81+
using(var response = await _fixture.HttpClient.GetAsync($"/{Constants.Streams.Stream}/a-stream/0"))
8282
{
8383
response.StatusCode.ShouldBe(HttpStatusCode.NotFound);
8484
response.Headers.ETag.ShouldBeNull();
@@ -94,14 +94,14 @@ public async Task delete_single_message_by_message_id()
9494

9595
var messageId = page.Messages[0].MessageId;
9696

97-
using(var response = await _fixture.HttpClient.DeleteAsync($"/streams/a-stream/{messageId}"))
97+
using(var response = await _fixture.HttpClient.DeleteAsync($"/{Constants.Streams.Stream}/a-stream/{messageId}"))
9898
{
9999
response.StatusCode.ShouldBe(HttpStatusCode.NoContent);
100100
response.Content.Headers.ContentLength.HasValue.ShouldBeTrue();
101101
response.Content.Headers.ContentLength.Value.ShouldBe(0);
102102
}
103103

104-
using(var response = await _fixture.HttpClient.GetAsync("/streams/a-stream/0"))
104+
using(var response = await _fixture.HttpClient.GetAsync($"/{Constants.Streams.Stream}/a-stream/0"))
105105
{
106106
response.StatusCode.ShouldBe(HttpStatusCode.NotFound);
107107
response.Headers.ETag.ShouldBeNull();

‎src/SqlStreamStore.HAL.Tests/StreamMetadataTests.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public async Task get_metadata_when_metadata_stream_does_not_exist()
2727
{
2828
using(var response =
2929
await _fixture.HttpClient.SendAsync(
30-
new HttpRequestMessage(HttpMethod.Get, $"/streams/{StreamId}/metadata")))
30+
new HttpRequestMessage(HttpMethod.Get, $"/{Constants.Streams.Stream}/{StreamId}/metadata")))
3131
{
3232
response.StatusCode.ShouldBe(HttpStatusCode.NotFound);
3333
response.Headers.ETag.ShouldBe(new EntityTagHeaderValue(@"""-1"""));
@@ -54,7 +54,7 @@ await _fixture.HttpClient.SendAsync(
5454
public async Task get_metadata_when_metadata_stream_does_exist()
5555
{
5656
using(await _fixture.HttpClient.SendAsync(
57-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}/metadata")
57+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}/metadata")
5858
{
5959
Content = new StringContent(JObject.FromObject(new
6060
{
@@ -74,7 +74,7 @@ public async Task get_metadata_when_metadata_stream_does_exist()
7474
}))
7575
using(var response =
7676
await _fixture.HttpClient.SendAsync(
77-
new HttpRequestMessage(HttpMethod.Get, $"/streams/{StreamId}/metadata")))
77+
new HttpRequestMessage(HttpMethod.Get, $"/{Constants.Streams.Stream}/{StreamId}/metadata")))
7878
{
7979
response.StatusCode.ShouldBe(HttpStatusCode.OK);
8080
response.Headers.ETag.ShouldBe(new EntityTagHeaderValue(@"""0"""));
@@ -105,7 +105,7 @@ await _fixture.HttpClient.SendAsync(
105105
public async Task set_metadata()
106106
{
107107
using(var response = await _fixture.HttpClient.SendAsync(
108-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}/metadata")
108+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}/metadata")
109109
{
110110
Content = new StringContent(JObject.FromObject(new
111111
{
@@ -163,7 +163,7 @@ public async Task set_wrong_expected_version(int[] expectedVersions)
163163
for(var i = 0; i < expectedVersions.Length - 1; i++)
164164
{
165165
using(await _fixture.HttpClient.SendAsync(
166-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}/metadata")
166+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}/metadata")
167167
{
168168
Headers =
169169
{
@@ -189,7 +189,7 @@ public async Task set_wrong_expected_version(int[] expectedVersions)
189189
}
190190

191191
using(var response = await _fixture.HttpClient.SendAsync(
192-
new HttpRequestMessage(HttpMethod.Post, $"/streams/{StreamId}/metadata")
192+
new HttpRequestMessage(HttpMethod.Post, $"/{Constants.Streams.Stream}/{StreamId}/metadata")
193193
{
194194
Headers =
195195
{

‎src/SqlStreamStore.HAL.Tests/StreamNavigationTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ public async Task read_stream_should_include_the_last_position_and_version()
173173

174174
var page = await _fixture.StreamStore.ReadStreamForwards(StreamId, StreamVersion.Start, 10, false);
175175

176-
using(var response = await _fixture.HttpClient.GetAsync("/streams/a-stream"))
176+
using(var response = await _fixture.HttpClient.GetAsync($"/{Constants.Streams.Stream}/a-stream"))
177177
{
178178
response.StatusCode.ShouldBe(HttpStatusCode.OK);
179179

0 commit comments

Comments
 (0)