Improved performance of InclusionService

[Deipher]

Exclusions and inclusions are only checked if they have been set.

[SQiShER]

Cool, thanks! I'd be happy to merge it into the master.

Unfortunately your code formatter was a little bit too aggressive, so that Git now thinks that pretty much the entire file has changed. That makes it hard to see what you actually changed. Since I'm currently also working on the InclusionService on a different branch, that would make it pretty hard to merge it back into the master without breaking your changes.

Could you please update your pull request, so that the original code style (line breaks, etc) and ordering remains intact and the git/github diff better reflects your changes?

[Deipher]

Sorry for that. I just pasted the modified code from Eclipse with our custom formater.
I updated the file directly under Github i hope it's now better.

[SQiShER]

Hmm, not quite. We need to get rid of the initial commit. Either you squash your commits into one or simply open a new pull request with the final state. Thanks!

[Deipher]

Hello Daniel,

In order to plan our deliveries, do you have a due date for the release of
the version 0.91 of your library ? :)

Thx in advance.

Best regards.

2014-10-27 16:04 GMT+01:00 Daniel Bechler notifications@github.com:

Hmm, not quite. We need to get rid of the initial commit. Either you
squash your commits into one or simply open a new pull request with the
final state. Thanks!

—
Reply to this email directly or view it on GitHub
#111 (comment)
.

[SQiShER]

I'd like to write some more tests for the new features, but I think I can release the new version tonight.

[Deipher]

Ok :) Take your time, we just wanted to have an idea of the release date :)

2014-11-05 13:34 GMT+01:00 Daniel Bechler notifications@github.com:

I'd like to write some more tests for the new features, but I think I can
release the new version tonight.

—
Reply to this email directly or view it on GitHub
#111 (comment)
.

[SQiShER]

In that case I think, I'll take my time and do it over the weekend. 😉

[Deipher]

Yes :)

2014-11-05 23:47 GMT+01:00 Daniel Bechler notifications@github.com:

In that case I think, I'll take my time and do it over the weekend. [image:
😉]

—
Reply to this email directly or view it on GitHub
#111 (comment)
.

[Deipher]

Hello there,

I was that the version 0.91 is out but i can't find it under Maven
Repository :
http://mvnrepository.com/artifact/de.danielbechler/java-object-diff

Is it normal ?

Best regards.

2014-11-06 9:41 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

Yes :)

2014-11-05 23:47 GMT+01:00 Daniel Bechler notifications@github.com:

In that case I think, I'll take my time and do it over the weekend. [image:
😉]

—
Reply to this email directly or view it on GitHub
#111 (comment)
.

[SQiShER]

Hmm, strange. I never actively did anything to make it available at mvnrepository.com. All I normally do is to sync it to Maven Central. And it looks like that worked. I could imagine, that mvnrepository.com simply crawls the central repository and didn't do it since the release 4 days ago.

[Deipher]

Maybe we should wait a little bit :)

2014-11-13 17:41 GMT+01:00 Daniel Bechler notifications@github.com:

Hmm, strange. I never actively did anything to make it available at
mvnrepository.com. All I normally do is to sync it to Maven Central. And
it looks like that worked
http://search.maven.org/#search%7Cga%7C1%7Cjava-object-diff. I could
imagine, that mvnrepository.com simply crawls the central repository and
didn't do it since the release 4 days ago.

—
Reply to this email directly or view it on GitHub
#111 (comment)
.