Use ExternalProject for googletest #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for provinding this! |
|
Yeah it's the yml files, I'll fix them now |
timrae
force-pushed
the
use-gtest-github
branch
from
09a8bcb to
af133ad
Compare
|
Ugh, it looks like it's still failing on the Windows builds because I used |
timrae
force-pushed
the
use-gtest-github
branch
from
af133ad to
6215968
Compare
timrae
force-pushed
the
use-gtest-github
branch
from
6215968 to
e241ede
Compare
timrae
commented
Dec 5, 2016
| add_executable(SQLiteCpp_tests ${SQLITECPP_TESTS}) | ||
| target_link_libraries(SQLiteCpp_tests gtest_main SQLiteCpp sqlite3) | ||
| add_dependencies(SQLiteCpp_tests googletest) | ||
| set(GTEST_MAIN_OBJ ${PREFIX_DIR}/src/googletest-build/googlemock/gtest/${LIB_PREFIX}gtest_main${LIB_SUFFIX}) |
There was a problem hiding this comment.
@SRombauts
Sorry I don't have access to a Windows C++ environment, so I don't know where these gtest binaries are being generated and what they're called there. On linux they're called libgtest.a and libgtest_main.a. Would you be able to check what's happening on Windows?
There was a problem hiding this comment.
Sure, I'll try this at some point.
SRombauts
force-pushed
the
master
branch
2 times, most recently
from
ce6f94c to
3f3b174
Compare
|
Closing, would need some serious rework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some TODO comments about using the official github directly from the cmake file, and due to some issues with cmake I can't use projects with submodules in my organization, so I went ahead and updated the cmake file.