Skip to content

fix: do not crash when performing "sibling-related" operations on the root node #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: do not crash when performing "sibling-related" operations on the root node #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/utils/objectManipulation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import type { NodeObj } from '../types'

const getSibling = (obj: NodeObj): { siblings: NodeObj[]; index: number } => {
const getSibling = (obj: NodeObj): { siblings: NodeObj[]|undefined; index: number } => {
const siblings = obj.parent?.children as NodeObj[]
const index = siblings.indexOf(obj)
const index = siblings?.indexOf(obj) ?? 0
return { siblings, index }
}

export function moveUpObj(obj: NodeObj) {
const { siblings, index } = getSibling(obj)
if (siblings === undefined) return
const t = siblings[index]
if (index === 0) {
siblings[index] = siblings[siblings.length - 1]
Expand All @@ -20,6 +21,7 @@ export function moveUpObj(obj: NodeObj) {

export function moveDownObj(obj: NodeObj) {
const { siblings, index } = getSibling(obj)
if (siblings === undefined) return
const t = siblings[index]
if (index === siblings.length - 1) {
siblings[index] = siblings[0]
Expand All @@ -32,12 +34,14 @@ export function moveDownObj(obj: NodeObj) {

export function removeNodeObj(obj: NodeObj) {
const { siblings, index } = getSibling(obj)
if (siblings === undefined) return 0
siblings.splice(index, 1)
return siblings.length
}

export function insertNodeObj(newObj: NodeObj, type: 'before' | 'after', obj: NodeObj) {
const { siblings, index } = getSibling(obj)
if (siblings === undefined) return
if (type === 'before') {
siblings.splice(index, 0, newObj)
} else {
Expand All @@ -47,6 +51,7 @@ export function insertNodeObj(newObj: NodeObj, type: 'before' | 'after', obj: No

export function insertParentNodeObj(obj: NodeObj, newObj: NodeObj) {
const { siblings, index } = getSibling(obj)
if (siblings === undefined) return
siblings[index] = newObj
newObj.children = [obj]
}
Expand All @@ -59,6 +64,7 @@ export function moveNodeObj(type: 'in' | 'before' | 'after', from: NodeObj, to:
} else {
if (from.direction !== undefined) from.direction = to.direction
const { siblings, index } = getSibling(to)
if (siblings === undefined) return
if (type === 'before') {
siblings.splice(index, 0, from)
} else {
Expand Down