[Bug] Parser breaks on declares by ordinal

[sancarn]

Describe the bug

Parser breaks on declares by ordinal:

Private Declare PtrSafe Function IUnknown_GetWindow Lib "shlwapi" Alias "#172" (ByVal pIUnk As IUnknown, ByVal hwnd As LongPtr) As Long

Should be a simple fix, currently antlr grammar is as follows:

aliasClause: ALIAS wsc STRINGLITERAL;

Needs changing to

aliasClause: ALIAS wsc stringOrOrdinal;
stringOrOrdinal
     : STRINGLITERAL
    | ORDINALSTRING
    ;
ORDINALSTRING
    : '"#' [0-9]+ '"'
    ;

I can likely PR, but just not sure how to build/test... Any instructions? 😅

[SSlinky]

Have been a bit MIA sorry! Too much work on. I'd love it if you were able to invest some time.

I've written a contributing page if that helps. Appreciate that it's not super straight forward getting started with this project.

[sancarn]

Have been a bit MIA sorry! Too much work on. I'd love it if you were able to invest some time.

I feel ya 👍 Thanks, for the contributing page, instructions seem simple enough, will see if I can get it up and running on my end to enable PRs😄

[sancarn]

I've written a contributing page if that helps.

@SSlinky What do you mean by "Use the Client + Server launch configuration"? I can't see any scripts in the client nor server... Is there any guidance on this online?

---

So I've tried npm run compile (but am getting some ts errors (see below)) and then running by clicking F5 in with the folder open in the workspace, but without the compilation succeeding I'm not expecting this to work xD

TS Errors:

node_modules/antlr4ng/dist/tree/pattern/ParseTreePatternMatcher.d.ts:87:54 - error TS2304: Cannot find name 'ErrorOptions'.

87         new (message?: string | undefined, options?: ErrorOptions | undefined): {
                                                        ~~~~~~~~~~~~

server/src/project/parser/vbaSyntaxParser.ts:23:13 - error TS2554: Expected 2 arguments, but got 3.

23             token
               ~~~~~


Found 2 errors.

Little confused with the first one, because that's a node module....? Though I did find this: mike-lischke/antlr4ng#45 - but still, unsure how it can be working for yourself 😅 And also am not fully sure whether I am doing the right commands in the first place 😅

[SSlinky]

Ahh, this is me assuming you're using vscode to develop. I was referring to this file - /.vscode/launch.json. Should be able to see it in the list of launch configurations.

[sancarn]

Ahhh that makes a lot of sense 😅 Maybe worth adding to contributing markdown 😁 I'll give that a go and see if I can get it running ☺️

[SSlinky]

How did you go, mate? Let me know if you want me to jump in and take credit for your work. Also, I've just committed to both master and dev so you'll need to pull :)

[sancarn]

Hey @SSlinky, I apologise I haven't had an awful lot of time recently to get back in the swing of things 😅 by all means take the credit I'm sure there will be more I can contribute on 😁 most important imo is it gets fixed 😁

[SSlinky]

Somewhat of a red herring but I got there eventually. It was an issue with enum being declared LongPtr as this is not an ambiguous name. All good. I've added this specific type of enum declaration and it's all working again. Published patch 1.4.5.