[Bug] Syntax highlighting issues

[sancarn]

Describe the bug

Not sure if this is singular to me, but there are numerous syntax highlighting issues

Set looks incorrect - usually is dark blue, but unsure how this should be defined.

If okay but sometimes not:

To Reproduce

Load stdAcc

[sancarn]

More issues see WIP/stdEndpoint:

Imagine the alias issue is basically because of a trivial textmate issue.

See stdCOM:

Same issue with enums

Is should be an operator. Nothing maybe should have special highlighting?

Edit1 - Found another big one

Edit 2 - Just found this one:

[SSlinky]

I've fixed the Set issue but I'll have to come back to the others. The On Error one is really weird. It works wherever you put that line except where it is!

[sancarn]

The On Error one is really weird. It works wherever you put that line except where it is!

That sounds incredibly bizarre...

[SSlinky]

Commit de4c923 addresses the On Error issue. Have published a patch version.

[SSlinky]

Commit de4c923 addresses the On Error issue. Have published a patch version.

"Addresses" is perhaps too strong. Looks like it's something to do with If statements completely breaking a method.

[SSlinky]

Have addressed some issues with syntax in 3732004. This is what happens when you take nine months off a project. You forget there were issues with it! I've also made some significant improvements to performance. Your stdAcc was killing it, so I've programmed it not to attempt to parse it at all.

I kid. Sort of. I added a 1 second delay to kicking off the parser. If another onDocumentChange is received, it doesn't do anything. So only the most recent request - assuming no changes in second - is processed.

If you switch to the pre-release version, you should see these changes. Enough for tonight. Nearly 3am.

[sancarn]

This is what happens when you take nine months off a project. You forget there were issues with it

Haha I feel you on that one lol. Many stdVBA files have a similar story when it comes to releases 😅

Your stdAcc was killing it

Yeah I was noticing the same, took like 10 minutes to produce the outline 😄 Adding the 1 second delay makes a lot of sense!

Nearly 3am

An all to regular occurrence for me 😅

---

FYI, Set keyword in this code is not highlighted.

  With This.Factory
    Set .OnInit = OnInit
    Set .OnDestroy = OnDestroy
  End With

I imagine it would be a good idea to use @Beakerboy 's antlr grammar as it contains a number of fixes including this one. Though I imagine that would be a major change.

Edit:

Maybe not, given it was from the same source library

[Beakerboy]

My dev ANTLR grammer has a lot of improvements over the one in the main ANTLR repository. I need to actually submit it to the organization for inclusion as a new VBA7 grammer. The existing one is supposed to only be VBA6.

[SSlinky]

I imagine it would be a good idea to use @Beakerboy 's antlr grammar

Not a bad suggestion. I've made some changes on the original to make things easier to resolve in the server, but not a whole lot. This particular Set issue is the Textmate grammar though.