Improved overflow support: Internal EventHandlingWatch interface
#19
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## improved-overflow-support-main #19 +/- ##
==================================================================
- Coverage 80.5% 80.3% -0.2%
- Complexity 91 94 +3
==================================================================
Files 11 12 +1
Lines 416 428 +12
Branches 41 41
==================================================================
+ Hits 335 344 +9
- Misses 59 61 +2
- Partials 22 23 +1 ☔ View full report in Codecov by Sentry. |
…erflow-support/richer-active-watch
…support/richer-active-watch
sungshik
changed the title
ActiveWatchActiveWatch interface
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
I want to keep ActiveWatch as small and focussed as possible.
| * file system libraries trigger the event handler "from the inside"). This | ||
| * is useful to report synthetic events (e.g., while handling overflows). | ||
| */ | ||
| void handleEvent(WatchEvent event); |
There was a problem hiding this comment.
In a public interface, this feels a bit weird, I want to keep this interface as small as possible, to allow us to improve the API without breaking compatibility.
Maybe this should be an internal/private interface?
There was a problem hiding this comment.
Agreed. I've extracted handleEvent and relativize into a separate interface in the impl package, called EventHandlingWatch.
sungshik
changed the title
ActiveWatch interfaceEventHandlingWatch interface
sungshik
changed the title
EventHandlingWatch interfaceEventHandlingWatch interface
2 participants
This PR adds a new internal interface,
EventHandlingWatch, which extends the existing external interfaceActiveWatch. In the next PRs,EventHandlingWatchwill be generically used as a type in overflow event handlers instead ofJDK...Watch. That's useful because these overflow handlers may also be used by non-JDK watches.