Improved overflow support: Overflow auto-handling for file watches #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file in `JDKFileWatch` (including tests)
…mproved-overflow-support/overflow-policies-for-file-watches
sungshik
commented
Mar 5, 2025
Contributor
Author
sungshik
left a comment
sungshik
left a comment
There was a problem hiding this comment.
Clarifying comment
| } | ||
| case PATH_ONLY: { | ||
| var result = new JDKFileWatch(path, executor, eventHandler); | ||
| var result = new JDKFileWatch(path, executor, h); |
Contributor
Author
There was a problem hiding this comment.
Missing context: h is the compound event handler that consists of: (a) the user-defined eventHandler; (b) the overflow auto-handler that generates synthetic events
Base automatically changed from
improved-overflow-support/first-overflow-policy
to
improved-overflow-support-main
March 7, 2025 10:17
…support/overflow-policies-for-file-watches
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-overflow-support-main #25 +/- ##
==================================================================
+ Coverage 79.7% 80.6% +0.9%
- Complexity 107 111 +4
==================================================================
Files 14 14
Lines 483 486 +3
Branches 46 47 +1
==================================================================
+ Hits 385 392 +7
+ Misses 70 67 -3
+ Partials 28 27 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DavyLandman
approved these changes
Mar 7, 2025
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
LGTM, just 1 improvement for the test I would like to propose
sungshik
deleted the
improved-overflow-support/overflow-policies-for-file-watches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this comment: in
JDKFileWatch, overflow events should be propagated from the parent directory being "physically" watched to the file being "logically" watched.The general auto-handling of overflows immediately works as-is, as shown by the tests (added in this PR as well).