Improved overflow support: Fix detection of DELETED events in IndexingRescanner
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## improved-overflow-support-main #28 +/- ##
==================================================================
+ Coverage 79.2% 80.8% +1.6%
- Complexity 119 120 +1
==================================================================
Files 16 16
Lines 539 549 +10
Branches 53 54 +1
==================================================================
+ Hits 427 444 +17
+ Misses 81 74 -7
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DavyLandman
approved these changes
Mar 26, 2025
| // approximate `DELETED` events that happened since the previous rescan. | ||
| // Instances of this class are supposed to be used non-concurrently, so | ||
| // no synchronization to access this field is needed. | ||
| private Deque<Set<Path>> visited = new ArrayDeque<>(); |
sungshik
changed the title
DELETED events in IndexingRescannerDELETED events in IndexingRescanner
sungshik
deleted the
improved-overflow-support/fix-delete-detection-in-indexing-rescanner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, too many
DELETEDevents were issued byIndexingRescannerin the situation where the initial index is larger than the set of files in the scope of the watch. This PR adds a test to expose this misbehavior and a fix.