Skip to content

Conversation

@DavyLandman
Copy link
Member

This PR fixes #57 and also changes the default thread pool that is used when users do not provide their own.

This way commonPool is not polluted by long running jobs.

@DavyLandman DavyLandman force-pushed the fix/non-deamon-threads branch from 0fd9957 to 088f895 Compare July 10, 2025 09:32
This way the default will make it harder to get users in a bad situation and provide a helper class that users might like to re-use.
@DavyLandman DavyLandman force-pushed the fix/non-deamon-threads branch from 088f895 to f433eb2 Compare July 10, 2025 09:38
@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.0%. Comparing base (24af885) to head (f433eb2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/engineering/swat/watch/Watch.java 75.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              main     #59     +/-   ##
=========================================
+ Coverage     81.6%   82.0%   +0.4%     
- Complexity     164     169      +5     
=========================================
  Files           23      24      +1     
  Lines          828     841     +13     
  Branches        97      98      +1     
=========================================
+ Hits           676     690     +14     
  Misses          92      92             
+ Partials        60      59      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DavyLandman DavyLandman merged commit 998d49a into main Jul 10, 2025
19 checks passed
@DavyLandman DavyLandman deleted the fix/non-deamon-threads branch July 10, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JDK Poller thread keeps the process alive

1 participant