Skip to content

Conversation

@klieret
Copy link
Member

@klieret klieret commented Oct 9, 2025

  • Comparison plots part 1
  • Quick select for plots; light mode
  • New plot: Cost performance scatter plot
  • Add quick-select checkbox for analysis
  • Analysis plots: Visual improvements
  • Enh(analysis): Add download data buttons and more

@Chesars
Copy link
Contributor

Chesars commented Oct 23, 2025

Hi, this is great! I just tested it locally and it works very well. The new charts and modular structure look really good. Left a couple of suggestions in the comments, happy to open a follow-up PR with those changes if helpful. But this is excellent overall. Congrats! 👏

@klieret
Copy link
Member Author

klieret commented Nov 19, 2025

thanks @Chesars . didn't see the comments, perhaps you might have to click "finish review" or somethign? (github is kinda weird, it typically queues up the review comments)

@klieret klieret merged commit a0304f2 into master Nov 19, 2025
@Chesars
Copy link
Contributor

Chesars commented Nov 19, 2025

thanks @Chesars . didn't see the comments, perhaps you might have to click "finish review" or somethign? (github is kinda weird, it typically queues up the review comments)

You're welcome @klieret . Oh, yes, you were right, I clicked "submit comments" and they were sent.

@klieret
Copy link
Member Author

klieret commented Nov 19, 2025

Thanks for the review @Chesars actually spotted and fixed an issue with the light/dark mode, it's now similar to what you suggested (but keeping the duplicate button)

@klieret klieret deleted the add-comparison-plots branch November 19, 2025 18:36
@Chesars
Copy link
Contributor

Chesars commented Nov 19, 2025

Thanks for the review @Chesars actually spotted and fixed an issue with the light/dark mode, it's now similar to what you suggested (but keeping the duplicate button)

Awesome @klieret 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants