Skip to content

consistent alpharom stylization #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

consistent alpharom stylization #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BinaryObjectScanner/Protection/AlphaROM.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public class AlphaROM : IDiskImageCheck<ISO9660>, IExecutableCheck<PortableExecu
&& Array.FindAll(applicationIdentifierStringBytes, b => b < 60).Length >= 5
&& Array.FindAll(applicationIdentifierStringBytes, b => b > 60).Length >= 5)
{
return "AlphaROM";
return "Alpha-ROM";
}

// Type #2: Usually 20 characters long, but Redump ID 124334 is 18 characters long. Validate that it
Expand All @@ -107,7 +107,7 @@ public class AlphaROM : IDiskImageCheck<ISO9660>, IExecutableCheck<PortableExecu
var startingNumbers = Encoding.ASCII.GetBytes(applicationIdentifierString.Substring(0, index));
var finalCharacters = Encoding.ASCII.GetBytes(applicationIdentifierString.Substring(index));
if (Array.TrueForAll(startingNumbers, b => b < 60) && Array.TrueForAll(finalCharacters, b => b > 60))
return "AlphaROM";
return "Alpha-ROM";
}

return null;
Expand Down