Skip to content

Conversation

@BryanFauble
Copy link
Member

Problem:

  • When creating a new grid session we have an opportunity to attach back to an active session when the user is using a record_set_id
  • Integration tests were needed in order to test out the logic, which is now available in the dev environment
  • Could not delete a grid session

Solution:

  • Allow attaching back to active grid session when creating one for an existing record_set_id
  • Allowing deleting grid sessions
  • Adding in tests

Testing:

  • Integration tests to cover logic



class GridSynchronousProtocol(Protocol):
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is here and not in the Protocols folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started to prefer that they end up being in the same python script so they're "next" to eachother and easier to see what's really going on, but both are valid.

@BryanFauble BryanFauble marked this pull request as ready for review October 15, 2025 19:33
@BryanFauble BryanFauble requested a review from a team as a code owner October 15, 2025 19:33
Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BryanFauble ! Thanks for your hard work. I tested out most of the examples, and they all worked great. I saw project_id="syn9876543" got included in multiple examples in the docstring, and I am thinking you might want to change it to a test project id?

I noticed you can start a grid session with grid.create(). But how do you edit the grid programmatically in Python? Or the grid will have to be edited in the UI? And is it possible to have multiple active grid sessions? If so, which session will you get when you run grid.create(attach_to_previous_session=True)?

@BryanFauble BryanFauble merged commit 8ba2953 into synpy-1653-metadata-tasks-and-recordsets Oct 16, 2025
19 of 26 checks passed
@thomasyu888 thomasyu888 deleted the synpy-1653-adding-grid branch October 23, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants