Skip to content

Conversation

@PiyushRaj927
Copy link
Collaborator

@PiyushRaj927 PiyushRaj927 commented May 31, 2023

Fixes #8

  1. Installed the required build dependency.
  2. Downloaded pgautofailover v2.0 from https://github.com/hapostgres/pg_auto_failoverand built it.
  3. Installed pgautofailover.
  4. Cleaned up the build dependencies.
  5. Updated the smoke test for pgautofailover.

Testing

I have test the images locally and have found no issues

Signed-off-by: Piyush Raj <piyushraj92739@gmail.com>
@PiyushRaj927 PiyushRaj927 marked this pull request as ready for review May 31, 2023 18:40
Signed-off-by: Piyush Raj <piyushraj92739@gmail.com>
@PiyushRaj927 PiyushRaj927 changed the title ADD PG Auto Failover [DOCKER] ADD PG Auto Failover May 31, 2023
@jayanth-kumar-morem
Copy link
Collaborator

Hi @PiyushRaj927 , The code looks clean, gave a few minor comments.

@PiyushRaj927
Copy link
Collaborator Author

Hey, @jayanth-kumar-morem, I'm having trouble viewing your comments. Could you please double-check them?

Signed-off-by: Piyush Raj <piyushraj92739@gmail.com>
Copy link
Collaborator

@jayanth-kumar-morem jayanth-kumar-morem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks Good To Me, @ChakshuGautam Please merge if you too are okay with the changes.

@ChakshuGautam ChakshuGautam merged commit 0149f51 into Samagra-Development:main Jun 1, 2023
@PiyushRaj927 PiyushRaj927 deleted the pg_auto_failover branch June 1, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PG Auto Failover

3 participants