Skip to content

Conversation

@zcysxy
Copy link
Contributor

@zcysxy zcysxy commented Mar 25, 2022

Related to #31. Seems like pretty straightforward.

To test it, I duplicated the katex-samples.html, changed all the id="..." to class="pseudocode", and replaced the script with

pseudocode.renderClass(document.getElementsByClassName("pseudocode"),
                                 {
                                     lineNumber: false,
                                     noEnd: true
                                 });

If there is no problem we can make it to the docs.

Copy link
Owner

@SaswatPadhi SaswatPadhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The logic looks good to me, but I think the API could be improved.

Also, please add an example usage snippet to README.md in Step 4.

@SaswatPadhi SaswatPadhi changed the title feat: render class renderClass API Mar 25, 2022
@SaswatPadhi SaswatPadhi linked an issue Mar 25, 2022 that may be closed by this pull request
zcysxy and others added 2 commits March 26, 2022 11:11
Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>
@zcysxy
Copy link
Contributor Author

zcysxy commented Mar 26, 2022

Thanks for the review, totally make sense! All changes are applied.

@SaswatPadhi
Copy link
Owner

Awesome, thank you so much! LGTM.

@SaswatPadhi SaswatPadhi merged commit 970c444 into SaswatPadhi:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Render Elements By Class Name

2 participants