This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Super class generics failing to find return type #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractJacksonFieldSnipplet.java - Updated to deal with superclass generic return type JacksonResponseFieldSnippetTest.java - Updated test objects to add super classes and interfaces - Added genericSuperMethod() test
cmercer
changed the title
AbstractJacksonFieldSnippet.java - Handle the cases there MethodParameter is a TypeVariable JacksonResponseFieldSnippet.java - Handle the cases where the return type is a TypeVariable -- public E getItem() JacksonResponseFieldSnippetTest.java - Tests cases for TypeVariable return type
ScaCap#311 More Generics fixes
fbenz
approved these changes
Apr 10, 2019
Contributor
fbenz
left a comment
fbenz
left a comment
There was a problem hiding this comment.
Thank you for adding support for superclass generic. I have only cosmetic comments.
...stdocs-core/src/main/java/capital/scalable/restdocs/payload/AbstractJacksonFieldSnippet.java
Outdated
Show resolved
Hide resolved
...stdocs-core/src/main/java/capital/scalable/restdocs/payload/AbstractJacksonFieldSnippet.java
Outdated
Show resolved
Hide resolved
Formatting feedback
jmisur
approved these changes
Apr 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#311