Extend the handleOnConfig from the PS library so we are able to include an engine version to determine if we need to send our WebRTC offer from the frontend or from the UE instance #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de an engine version. The engine version is then used to determine if we need to send our WebRTC offer from the frontend or from the UE instance
david-macpherson
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
We needed a way to differentiate what engine version was being negotiated via WebRTC as their behaviour can differ from version to version. Specifically, we wanted a way to be able to say when we should be sending WebRTC offers from the frontend and when we should be sending WebRTC offers from the instance.
Solution
This PR allows the frontend to receive a custom config message from the signalling server that includes the engine version of the instance that the frontend is attempting to negotiate it's WebRTC handshake with. Using this engine version, we override the flag that tells the frontend whether or not to send the WebRTC offer.
We only send a WebRTC offer from the frontend when the engine version is 4.27 or when it is empty.
Documentation
N/A
Test Plan and Compatibility
Testing across engine versions for both Linux and Windows.