Skip to content

Replaced the logic to send the offer from the frontend depending on what is sent from the signalling server #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2023
Merged

Replaced the logic to send the offer from the frontend depending on what is sent from the signalling server #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f30cb
Replaced the logic to send the offer from the frontend depending on w…
david-macpherson May 16, 2023
6f96953
Added missed semicolons
david-macpherson May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions examples/typescript/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@ declare var WEBSOCKET_URL: string;
// Extend the MessageRecv to allow the engine version to exist as part of our config message from the signalling server
class MessageExtendedConfig extends MessageRecv {
peerConnectionOptions: RTCConfiguration;
engineVersion: string
engineVersion: string;
platform: string;
frontendToSendOffer: boolean;
};

// Extend PixelStreaming to use our custom extended config that includes the engine version
class ScalablePixelStreaming extends PixelStreaming {
// Create a new method that retains original functionality
public handleOnConfig(messageExtendedConfig: MessageExtendedConfig) {
this._webRtcController.handleOnConfigMessage(messageExtendedConfig)
this._webRtcController.handleOnConfigMessage(messageExtendedConfig);
}
};

Expand All @@ -29,16 +31,15 @@ document.body.onload = function () {
// make usage of WEBSOCKET_URL if it is not empty
let webSocketAddress = WEBSOCKET_URL;
if (webSocketAddress != "") {
config.setTextSetting(TextParameters.SignallingServerUrl, webSocketAddress)
config.setTextSetting(TextParameters.SignallingServerUrl, webSocketAddress);
}

// Create stream and spsApplication instances that implement the Epic Games Pixel Streaming Frontend PixelStreaming and Application types
const stream = new ScalablePixelStreaming(config);

// Override the onConfig so we can determine if we need to send the WebRTC offer based on the engine version
// If the engine version is 4.27 or not defined, the browser should send the offer. This is what the Scalable Pixel Streaming signalling server will be expecting.
// Override the onConfig so we can determine if we need to send the WebRTC offer based on what is sent from the signalling server
stream.webSocketController.onConfig = (messageExtendedConfig: MessageExtendedConfig) => {
stream.config.setFlagEnabled(Flags.BrowserSendOffer, (messageExtendedConfig.engineVersion == "4.27" || messageExtendedConfig.engineVersion == ""));
stream.config.setFlagEnabled(Flags.BrowserSendOffer, messageExtendedConfig.frontendToSendOffer);
stream.handleOnConfig(messageExtendedConfig);
}

Expand Down