Obinna/s3 en 2674 disable logging #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obinnascale3
added
documentation
alizenhom
reviewed
Aug 20, 2024
| disable_logging = False | ||
| ): | ||
| if disable_logging: | ||
| sys.stdout = open(os.devnull, "w") |
Collaborator
There was a problem hiding this comment.
can you explain what does this do?
alizenhom
reviewed
Aug 20, 2024
| print(Fore.BLUE + "Exporting spans to Langtrace cloud.." + Fore.RESET) | ||
| provider.add_span_processor(batch_processor_remote) | ||
|
|
||
| sys.stdout = sys.__stdout__ |
Collaborator
There was a problem hiding this comment.
can you explain what does this do?
alizenhom
reviewed
Aug 20, 2024
| The result of the export SUCCESS or FAILURE | ||
| """ | ||
| if not self.api_key: | ||
| if not self.api_key and not self.disable_logging: |
Collaborator
There was a problem hiding this comment.
i am thinking a bit about this,
this approach will work fine for now, but it's adding some tech debt to the langtrace and langtrace exporter
i would say a more scalable approach is the following
- make the disable logging as an enviroment variable not an option to be passed
- abstract all Prints with
Foreinto a seperate function inside utils, that recieves 2 arguments which are the message and the color - inside the abstracted method just check for the env variable if it's set then return and do not print other wise print normally
Suggested change
| if not self.api_key and not self.disable_logging: | |
| def log(message, color): | |
| disable_logging = os.environ['DISABLE_LOGGING'] | |
| if disable_logging: | |
| return | |
| print(color, message, FORE.reset) |
what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue to help is review the PR better and faster.
Checklist for adding new integration:
APISin constants folder.SERVICE_PROVIDERSin common.pypatch.pyandinstrumentation.pyfiles.all_instrumentationsin langtrace.py and to theInstrumentationTypein types.py files.