Skip to content

remove chunk addition to events of the span #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

remove chunk addition to events of the span #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/langtrace_python_sdk/instrumentation/cohere/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
get_llm_url,
get_span_name,
set_event_completion,
set_event_completion_chunk,
set_usage_attributes,
)
from langtrace.trace_attributes import Event, LLMSpanAttributes
Expand Down
3 changes: 0 additions & 3 deletions src/langtrace_python_sdk/instrumentation/gemini/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
get_span_name,
is_streaming,
set_event_completion,
set_event_completion_chunk,
set_span_attributes,
set_usage_attributes,
)
Expand Down Expand Up @@ -156,7 +155,6 @@ def build_streaming_response(span, response):
item_to_yield = item
complete_response += str(item.text)
yield item_to_yield
set_event_completion_chunk(span, item.text)
if hasattr(item, "usage_metadata"):
usage = item.usage_metadata
input_tokens = usage.prompt_token_count
Expand All @@ -176,7 +174,6 @@ async def abuild_streaming_response(span, response):
item_to_yield = item
complete_response += str(item.text)
yield item_to_yield
set_event_completion_chunk(span, item.text)
if hasattr(item, "usage_metadata"):
usage = item.usage_metadata
input_tokens = usage.prompt_token_count
Expand Down
9 changes: 0 additions & 9 deletions src/langtrace_python_sdk/instrumentation/groq/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
get_langtrace_attributes,
get_span_name,
set_event_completion,
set_event_completion_chunk,
set_usage_attributes,
)
from langtrace_python_sdk.constants.instrumentation.common import (
Expand Down Expand Up @@ -245,14 +244,6 @@ def handle_streaming_response(
else:
content = []

set_event_completion_chunk(
span,
(
"".join(content)
if len(content) > 0 and content[0] is not None
else ""
),
)
result_content.append(content[0] if len(content) > 0 else "")
yield chunk
finally:
Expand Down
1 change: 0 additions & 1 deletion src/langtrace_python_sdk/instrumentation/ollama/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
get_llm_url,
get_span_name,
set_event_completion,
set_event_completion_chunk,
)
from langtrace_python_sdk.utils.silently_fail import silently_fail
from langtrace_python_sdk.constants.instrumentation.common import SERVICE_PROVIDERS
Expand Down
2 changes: 1 addition & 1 deletion src/langtrace_python_sdk/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "2.2.23"
__version__ = "2.2.24"