Fix swapped arguments in Ollama instrumentation #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `usage` to mistral instrumentation
Arguments for `StreamWrapper` in `ageneric_patch` are swapped
Collaborator
|
Thanks for the PR |
karthikscale3
approved these changes
Nov 25, 2024
karthikscale3
added a commit
that referenced
this pull request
Nov 26, 2024
* remove logs * remove requirements * Bump version * Squash * minor * switch to http exporter * Fix swapped arguments in Ollama instrumentation (#416) Arguments for `StreamWrapper` in `ageneric_patch` are swapped Co-authored-by: Ali Waleed <ali@scale3labs.com> * Bump version (#417) --------- Co-authored-by: Nick Vinogradov <pyscht@gmail.com> Co-authored-by: Ali Waleed <ali@scale3labs.com>
Collaborator
|
This has been released in 3.3.10 |
karthikscale3
added a commit
that referenced
this pull request
Dec 1, 2024
* remove logs * remove requirements * Bump version * Squash * minor * switch to http exporter * Fix swapped arguments in Ollama instrumentation (#416) Arguments for `StreamWrapper` in `ageneric_patch` are swapped Co-authored-by: Ali Waleed <ali@scale3labs.com> * Bump version (#417) * add deepseek support (#419) --------- Co-authored-by: Nick Vinogradov <pyscht@gmail.com> Co-authored-by: Ali Waleed <ali@scale3labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments for
StreamWrapperinageneric_patchare swapped