Skip to content

Commit 927268e

Browse files
committed
Log username for support-tunnel open/close
Fixes #205 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
1 parent 862b762 commit 927268e

File tree

3 files changed

+18
-5
lines changed

3 files changed

+18
-5
lines changed

plugins/module_utils/support_tunnel.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,15 @@ def check_tunnel_status(cls, client: Client) -> SupportTunnel:
6969

7070
@staticmethod
7171
def open_tunnel(module: AnsibleModule, client: Client) -> None:
72-
client.get("/support-api/open", query={"code": module.params["code"]})
72+
query = {
73+
"code": module.params["code"],
74+
"user": client.username,
75+
}
76+
client.get("/support-api/open", query=query)
7377

7478
@staticmethod
7579
def close_tunnel(client: Client) -> None:
76-
client.get("/support-api/close")
80+
query = {
81+
"user": client.username,
82+
}
83+
client.get("/support-api/close", query=query)

tests/unit/plugins/conftest.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@
3434

3535
@pytest.fixture
3636
def client(mocker):
37-
return mocker.Mock(spec=Client)
37+
mock_client = mocker.Mock(spec=Client)
38+
mock_client.username = "mock_username"
39+
return mock_client
3840

3941

4042
@pytest.fixture

tests/unit/plugins/module_utils/test_support_tunnel.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,14 @@ def test_open_tunnel(self, create_module, client):
107107

108108
SupportTunnel.open_tunnel(module, client)
109109

110-
client.get.assert_called_with("/support-api/open", query={"code": 4422})
110+
client.get.assert_called_with(
111+
"/support-api/open", query={"code": 4422, "user": "mock_username"}
112+
)
111113

112114
def test_close_tunnel(self, client):
113115
client.get.return_value = Response(status=200, data="")
114116
SupportTunnel.close_tunnel(client)
115117

116-
client.get.assert_called_with("/support-api/close")
118+
client.get.assert_called_with(
119+
"/support-api/close", query={"user": "mock_username"}
120+
)

0 commit comments

Comments
 (0)