Ci docker image #164
Merged
Ci docker image #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
ci-docker-image
branch
from
cd18bfa to
4b4555e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will use a custom docker image to run CI tests. Before we started with
python:3.10-slim-buster, and need to runapt install make git jq ...,pip install *.requirements, andpip install ansibleeach time. All those tools will be part of our docker image.This is example job with new docker image - https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4384232780/jobs/7675462776. It took about 20 sec.
The image contains latest ansible-2.13. I expect we will need at some point built more images (for ansbible 2.13, 2.14, etc). This is reason
ARG ANSIBLE_CORE_VERSION=2.13.0parameter in Dockerfile - it allows to override ANSIBLE_CORE_VERSION outside of Dockerfile.The docker image is stored under my personal quay.io account. Everyone can be pulled it, but login is needed for pushing new image/tag. For time being, only I will be able to push. We will switch to arbitrary docker repo as soon as Scale Computing says they have some other preference.
Since image is build locally, it is build with docker cache disabled (
--no-cacheoption). Reason - when I will try to build new image after say 1 month, I do not want dockerd to use cached result fromapt update && apt install x y zcommand.