CI use SMB cleanup variables from integration_config.yml #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
anazobec
approved these changes
Mar 20, 2023
Collaborator
anazobec
left a comment
anazobec
left a comment
There was a problem hiding this comment.
Looks good, thank you. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially we had a configuration variable/secret for every possible line in
integration_config.yml. Later we decided to have wholeintegration_config.ymlexcept about 3 passwords as a single CI variable, and then we add only missing passwords to it.The
smb_cleanup.shwas not yet updated to get required configuration (SMB server, username etc) fromintegration_config.yml. This PR does this.CI job to show that
smb_cleanupintegration "test" does pass - https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4465664492/jobs/7842970112