Http put with content length #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Not strictly needed - ISO upload works also without Content-Length. But it seems reasonable. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
anazobec
approved these changes
Mar 22, 2023
Collaborator
anazobec
left a comment
anazobec
left a comment
There was a problem hiding this comment.
Looks good. The CI docs tests are failing though, but the failure doesn't seem to be related to these minor changes.
Collaborator
Author
|
#177 fixed the 'make docs' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is safer to always PUT binary data to HC3 with Content-Length HTTP header.
PUT is used only in api, iso (and in future in virtual_disk module).
This does fix uploading virtual disk using raw api module example -
examples/virtual_disk.yml.It will also allow integration test for virtual_disk_info module to pass (the test VD is uploaded using api module).