Integ test #192
Merged
Integ test #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
PolonaM
requested changes
Mar 31, 2023
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just refactoring content in
tests/integration/integration-config.yml. I want to be able to select SC_HOST for tests with a single line change. After this PR, we need to change onlysc_host, the username and password are moved from top-level.sc_usernameto.sc_config.<sc_host>.sc_username.In similar way, each
sc_hostwill have a different replication destination -sc_config.<sc_host>.sc_replication_dest_host. The presence or absence ofsc_replication_dest_hosttells us if host was configured with replication or not. This will be used later to decide if replication related tests can be run.In similar way we should be (later) able to add expected ICOS version, and expected next_update_version for each available test host. It is annoying to see tests are failing only because we cannot hard-code expected values.
Assigning everyone, as everyone needs to update local
integration-config.ymltoo.