Fixes for integration test on virtual nodes #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning was like tests/integration/integration_config.yml, line 79, column 5, found a duplicate dict key (smtp). Using last defined value only. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
This depends on HyperCore version. We need to know if cluster name can be changed, version can be upgraded, and if virtual disk feature is supported. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Also test replication factor is exactly as expected. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
ci-cluster-name
branch
from
c1c597a to
9d94a96
Compare
justinc1
changed the title
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
ci-cluster-name
branch
from
a992904 to
89746ab
Compare
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just want more integration tests to pass. Main problems are that sometimes test cluster does not support the needed feature (say virtual disks). The
integration_config.ymlis extended to allow detecting what cluster does offer.The PR does fix some of tests, but not all. I guess it should be viewed commit-by-commit. The main part is spliting larger files into smaller, to make them usable on different clusters.
virtual_disk/virtual_disk_info - on version 9.1 run tests, but expect error, and check error message is as expected.
cluster_name - on version 9.1 run test, but expect error, and check error message is as expected. We can however check if name returned by cluster_info is as expected ("HC3 System").
version_update_info - on version 9.1.14 we know 9.1.23 will be offered, test that. On version 9.2 - we know no updates will be offered, test that.
vm_replication_info/vm_replication - on cluster with no replication, we can only check that VM replication is correctly reported as not being replicated. We need to run test on .50 test cluster to actually test replication.
This is an older CI job where those tests were failing: https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4565210170/jobs/8056036571
A new job: https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4605693676. After one retry (due to connection refused error), most jobs should pass.