CI try to fix check_local_time integ test #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jobs https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4675127388/jobs/8279941573#step:8:52 and https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4675127388/jobs/8279941761#step:8:52 failed Extra debug print added. It is not clear what were input values, and what went wrong. Tested interval is also changed, this should make test more reliable. Downside is test cannot work 2 hours in a day - there is extra assert just to fail early when this happens. It should not happen during scheduled CI jobs. Removed the extra "" in asserts. We were checking string is not empty, but we need to let assert evaluate string. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
fix-test-check-local-time
branch
from
c55c5ad to
ed5f1ea
Compare
PolonaM
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4675127388/jobs/8279941573#step:8:52 and
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4675127388/jobs/8279941761#step:8:52 failed
Extra debug print added. It is not clear what were input values, and what went wrong.
Tested interval is also changed, this should make test more reliable.
Downside is test cannot work 2 hours in a day - there is extra assert just to fail early when this happens. It should not happen during scheduled CI jobs.
Removed the extra "" in asserts. We were checking string is not empty, but we need to let assert evaluate string.