Fix version update role #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinc1
force-pushed
the
fix-version-update-role
branch
from
ac1f6ed to
c7d6d1b
Compare
PolonaM
requested changes
Apr 12, 2023
hm... testing `ansible-test integration version_update` failed when run against NUC. NUC was never upgraded before. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
fix-version-update-role
branch
from
c7d6d1b to
363d1a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two corner cases fixed.
1st if cluster was never upgrade before, the
version_update_status_infomodule will returnrecord=None.2nd, after one upgrade failed (upgrade was initiated, after a while is stopped with "Failed to open update tunnel") the
version_update_status_infomodule does returnrecord.update_status=None.